Change in ovirt-engine[ovirt-engine-4.1]: core: adding support for fencing storage volume job
Code Review
gerrit at ovirt.org
Tue Jan 17 15:04:49 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: adding support for fencing storage volume job
......................................................................
core: adding support for fencing storage volume job
This patch adds the infrastracture required to fence volume related
jobs.
In case the host the job was sent to becomes non responsive before the
job was started, the engine may attempt to fence the operation using the
volume the job was supposed was performed on.
Fencing a volume job is done by incrementing the volume generation by a
predefined interval using the FenceVolumeJob command. If the fencing
operation succeeded, it'll be detect by the VdsmImagePoller on the next
polling attempt of the StorageJobCallback.
The next patch in the series adds use of the added infrastructure in the
CopyData command.
Change-Id: Ib51944d0ab3e16c837bb117589e8e22f9756b219
Bug-Url: http://bugzilla.redhat.com/1409125
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/FenceVolumeJobCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/VdsmImagePoller.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVolumeJobCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
6 files changed, 82 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/70553
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib51944d0ab3e16c837bb117589e8e22f9756b219
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list