Change in ovirt-engine[master]: core: improve the robusness of vm devices monitoring
Code Review
gerrit at ovirt.org
Wed Jan 18 13:24:29 UTC 2017
>From Arik Hadas <ahadas at redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: improve the robusness of vm devices monitoring
......................................................................
core: improve the robusness of vm devices monitoring
We should not add a device with no general type or device type.
Before this patch, we generated a log but then a NPE occurred
and the whole devices monitoring cycle was terminated - none of
the devices was updated.
This patch changes this so we will actually skip the invalid
device and continue to process the valid devices.
Change-Id: I74349fa53b9a23661924a66d4c20056e41cb3d08
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/70728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74349fa53b9a23661924a66d4c20056e41cb3d08
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list