Change in gerrit-admin[master]: Fix get_maj_version function

Code Review gerrit at ovirt.org
Wed Jan 18 14:20:28 UTC 2017


>From Shlomo Ben David <sbendavi at redhat.com>:

Shlomo Ben David has submitted this change and it was merged.

Change subject: Fix get_maj_version function
......................................................................


Fix get_maj_version function

The current function handled only target milestones with the following
convention: ovirt-<version>

Added a fix to handle target milestone with the following
convention as well: ovirt-<version>-[beta|alpha|rc]
Example: ovirt-4.1.0-beta

Change-Id: Ic505dddb756e3c18797cc6ed38be87dbdd7f1a47
Fixes: OVIRT-1046
Signed-off-by: Shlomi Ben-David <sbendavi at redhat.com>
---
M hooks/custom_hooks/check_target_milestone
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Shlomo Ben David: Verified; Looks good to me, approved
  Gil Shinar: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/70752
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic505dddb756e3c18797cc6ed38be87dbdd7f1a47
Gerrit-PatchSet: 1
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>


More information about the Engine-commits mailing list