Change in ovirt-engine[ovirt-engine-4.1]: core: StorageJobCallback - prevent NPE when there is no exec...

Code Review gerrit at ovirt.org
Thu Jan 19 11:48:53 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: StorageJobCallback - prevent NPE when there is no executing host
......................................................................


core: StorageJobCallback - prevent NPE when there is no executing host

When there is no executing host (may happen when hosts go no responsive
during the command execution for example), the StorageJobCallback may fail
with NPE when attempting to check the host status.

This patch prevents it, if there is no executing host the job status can
be considered as failed.

Change-Id: I394c6b6a88bee9ef58d25b4e7bd3e880685b9100
Bug-Url: https://bugzilla.redhat.com/1414675
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java
1 file changed, 50 insertions(+), 43 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/70806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I394c6b6a88bee9ef58d25b4e7bd3e880685b9100
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list