Change in ovirt-engine[master]: core: AddDiskCommand VM existence validation

[Code Review]

>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: AddDiskCommand VM existence validation
......................................................................


core: AddDiskCommand VM existence validation

Commit 801c1c introduce a subtle bug where parameters containing a
valid VmDiskElement object that points to a non-existent VM would result
in the command passing its validate() method, but adding a validation
error, which is an illegal combination (not to mention a logically wrong
one - adding a disk to a non-existent VM should just fail).

This patch fixes the bug in the production code and updates the test
accordingly to mock the VM where needed.

Change-Id: I32036397a5718d1833646c96a8dbf7aab59b5171
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
2 files changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/70247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I32036397a5718d1833646c96a8dbf7aab59b5171
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>