Change in ovirt-engine[master]: core: GlusterHooksCommandTest redundant stubbing
Code Review
gerrit at ovirt.org
Thu Jan 19 21:08:19 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GlusterHooksCommandTest redundant stubbing
......................................................................
core: GlusterHooksCommandTest redundant stubbing
Remove redundant [unused] stubbing. This unused stubbing has no effect
on the test, and just confuses the reader.
More importantly, newer Mockito versions are stricter by default, and
this will actually fail the test.
Change-Id: I8f1c71c831e602755447d145076508ddefde8be5
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/70238
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f1c71c831e602755447d145076508ddefde8be5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list