Change in ovirt-engine[master]: core: GlusterSyncJobTest argument matchers

[Code Review]

>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: GlusterSyncJobTest argument matchers
......................................................................


core: GlusterSyncJobTest argument matchers

While many of the actual underlying implementations of both the test and
the production code pass ArrayLists, this is not required by neither the
methods' contracts, or their internal logic. Having the matchers
explicitly verify that ArrayLists are passed (instead of just
Collections or Lists, as specified by the methods' contracts) poses an
unwarranted strictness on the test, causing it to test implementation
details instead of the contractual behavior, and potentially
[erroneously] fail if the underlying implementation is changed to use
some other, potentially better suited collection.

Change-Id: I3bd92ad97025390862d7636a8e009cc1f75d7fe1
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java
1 file changed, 16 insertions(+), 15 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/70230
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3bd92ad97025390862d7636a8e009cc1f75d7fe1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>