Change in ovirt-engine[master]: core: ScanStorageForUnregistedDisksCommandTest unused code

Code Review gerrit at ovirt.org
Fri Jan 20 09:44:57 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: ScanStorageForUnregistedDisksCommandTest unused code
......................................................................


core: ScanStorageForUnregistedDisksCommandTest unused code

generateQueryReturnValueForGetDiskImages was only ever called with
succeeded=true, making this argument useless. Inlining it then revealed
several code paths that were never used, so they could safely be
removed.

Change-Id: Ic411891e3c9c98af69c55dc33687529f8c19a5b4
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ScanStorageForUnregisteredDisksCommandTest.java
1 file changed, 3 insertions(+), 32 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/70250
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic411891e3c9c98af69c55dc33687529f8c19a5b4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list