Change in ovirt-engine[master]: core: UpdateVmCommandTest doReturn
Code Review
gerrit at ovirt.org
Sun Jan 22 20:48:32 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: UpdateVmCommandTest doReturn
......................................................................
core: UpdateVmCommandTest doReturn
Since the command is a @Spied object, it should be stubbed with the
doReturn syntax, not the when syntax.
Although this currently works, it will break in future version of
Mockito, so fixing this mistake now will help ensuring a safe transition
to newer versions of Mockito.
Change-Id: Id8aa75a5e4a85af3f102d374cb6726052b52e5fe
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/70262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8aa75a5e4a85af3f102d374cb6726052b52e5fe
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list