Change in ovirt-engine[master]: core: CommonVmPoolCommandTestAbstract domain mocks

Code Review gerrit at ovirt.org
Sun Jan 22 20:48:32 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: CommonVmPoolCommandTestAbstract domain mocks
......................................................................


core: CommonVmPoolCommandTestAbstract domain mocks

The mockFirstStorageDomain and mockSecondStorageDomain methods differ
only by the storage domain's ID.
This patch consolidates both methods and converts the storage domain
ID to a parameter.

Change-Id: Ic17c2bdf68ef050bb505953478e51bfcf7605a73
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolCommandTestAbstract.java
1 file changed, 5 insertions(+), 13 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/70259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic17c2bdf68ef050bb505953478e51bfcf7605a73
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list