Change in ovirt-engine[master]: core: Don't use anyCollectionOf(Class)

Code Review gerrit at ovirt.org
Mon Jan 23 07:17:34 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Don't use anyCollectionOf(Class)
......................................................................


core: Don't use anyCollectionOf(Class)

Mockito 1.x's anyCollection() returned a raw Collection, which would
cause unchecked assignment warning when it was used in a generic
context.
Mockito 2.x fixed this to return a Collection<T>, and uses Java 8's
capabilities to infer the generic type. As a result,
anyCollectionOf(Class) was deprecated, and will be removed in the near
future.

This patch removes all usages of anyCollectionOf(Class) and replaces
them with the recommended anyCollection().

Change-Id: I4506932c45937dd9e15172f289a8bcea097f6fc0
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelperTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidatorTest.java
3 files changed, 10 insertions(+), 13 deletions(-)

Approvals:
  Allon Mureinik: Verified; Passed CI tests
  Moti Asayag: Looks good to me, approved
  Idan Shaby: Looks good to me, but someone else must approve

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/70299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4506932c45937dd9e15172f289a8bcea097f6fc0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list