Change in ovirt-engine[master]: gwt-servlet: Log an Error when misusing multi queries

Code Review gerrit at ovirt.org
Tue Jan 24 11:08:18 UTC 2017


>From Roy Golan <rgolan at redhat.com>:

Roy Golan has submitted this change and it was merged.

Change subject: gwt-servlet: Log an Error when misusing multi queries
......................................................................


gwt-servlet: Log an Error when misusing multi queries

Logging an error now when the params and types passed do not much or are
null.

Unit test added to test the conditions.

Change-Id: Icdfb1d2e16dab6cc2e5e219a4533eef78924fabc
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImplTest.java
2 files changed, 103 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Roy Golan: Verified



-- 
To view, visit https://gerrit.ovirt.org/65829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icdfb1d2e16dab6cc2e5e219a4533eef78924fabc
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list