Change in ovirt-engine-sdk[sdk_4.0]: Check types of locator parameters
Code Review
gerrit at ovirt.org
Tue Jan 24 11:26:56 UTC 2017
>From Ondra Machacek <omachace at redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Check types of locator parameters
......................................................................
Check types of locator parameters
Currently the types of the parameters of locator methods aren't checked.
This patch addresses that issue, so that the parameters will be checked
and useful exceptions will be generated.
Change-Id: I8b170c5ee917701b56960d1ffe23d3833d8df833
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 86bd07f911864b8648c8b51532e6b8203d8f7028)
(cherry picked from commit b35abc2fc361b8db2c01619dd136696c0b7a66f0)
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
M sdk/tests/test_check_types.py
2 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71054
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b170c5ee917701b56960d1ffe23d3833d8df833
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list