Change in ovirt-engine[ovirt-engine-4.1]: core: StorageJobCallback - jobs fencing

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: StorageJobCallback - jobs fencing
......................................................................


core: StorageJobCallback - jobs fencing

When a job status can't be detected using entity polling the
StorageJobCallback will attempt to fence it in case it hasn't
started yet (when a job starts it's persisted in the command
parameters).

This patch changes the logic to attempt to fence the job even if it has
started, in case the job status can't be determined using entity polling
performing the fencing logic can confirm us that the operation has
failed on the next entity polling round.
Additionally, if the job has started and is stuck on a storage operation
we can still attempt to fence it using the entity. As the job should
modify the entity only after acquiring a cluster lock on it.

Change-Id: Ifdbab1c6e898b7791e6b05b62684f036c23cc3d4
Bug-Url: https://bugzilla.redhat.com/1415502
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageJobCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostJobInfo.java
3 files changed, 11 insertions(+), 35 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/71100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdbab1c6e898b7791e6b05b62684f036c23cc3d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>