Change in ovirt-engine[master]: engine: make AddVmCommandTestBase derrivatives strict
Code Review
gerrit at ovirt.org
Wed Jan 25 06:34:24 UTC 2017
>From Moti Asayag <masayag at redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: make AddVmCommandTestBase derrivatives strict
......................................................................
engine: make AddVmCommandTestBase derrivatives strict
Move the non-common mock expectations into the test cases that
actively use them and by that enable using "strict" runner.
Change-Id: I6a92e525e878b5de5bcd64691ce761553cf24a2d
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTestBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommandTest.java
4 files changed, 49 insertions(+), 71 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/71122
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a92e525e878b5de5bcd64691ce761553cf24a2d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list