Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Missing storage domain validated on FE

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Missing storage domain validated on FE
......................................................................


webadmin: Missing storage domain validated on FE

If a (non-admin) user creates a new VM based on template with disk that
is stored on storage domain that the user doesn't have pemissions to
then unitVmModel.getDisksAllocationModel().getDisks().get(...)
.getStorageDomain().getSelectedItem() may return `null`. This caused NPE
in DisksAllocationModel#updateImageToDestinationDomainMap().

The missing storage domain is reported as validation problem of Template
field.

Bug-Url: https://bugzilla.redhat.com/1406572
Change-Id: Ib41fa852aec8e8b428ef4c61c924c3c121f75f43
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
3 files changed, 27 insertions(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/71169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib41fa852aec8e8b428ef4c61c924c3c121f75f43
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>