Change in ovirt-engine-sdk-ruby[master]: Accept CA files and strings

Code Review gerrit at ovirt.org
Fri Jan 27 16:27:04 UTC 2017


>From Juan Hernandez <juan.hernandez at redhat.com>:

Juan Hernandez has submitted this change and it was merged.

Change subject: Accept CA files and strings
......................................................................


Accept CA files and strings

Currently the constructor of the 'Connection' class accepts the
'ca_file' option, which should contain the name of a file containing the
trusted CA certificates. This patch modifies it so that it also accepts
the 'ca_certs' option, containing an array of strings, each one
containing the PEM representation of one certificate.

Change-Id: I1f5ebc30147558fcd6093ba8f3a864a05517202a
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M sdk/lib/ovirtsdk4/connection.rb
M sdk/spec/connection_create_spec.rb
2 files changed, 93 insertions(+), 4 deletions(-)

Approvals:
  Beni Cherniavsky-Paskin: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/71186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f5ebc30147558fcd6093ba8f3a864a05517202a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Beni Cherniavsky-Paskin <cben at redhat.com>
Gerrit-Reviewer: Boris Odnopozov <bodnopoz at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list