Change in ovirt-hosted-engine-ha[master]: Always add console device

Code Review gerrit at ovirt.org
Mon Jan 30 15:30:46 UTC 2017


>From Martin Sivák <msivak at redhat.com>:

Martin Sivák has submitted this change and it was merged.

Change subject: Always add console device
......................................................................


Always add console device

When reading the vm ovf the console device was ignored.
This patch adds the console device if it exists in the ovf and
creates a stubbed device in case the ovf is missing it.
That way the console commands will not fail.

Change-Id: Id860888421097336a41b5a4612e58668de20c917
Bug-Url:https://bugzilla.redhat.com/1364132
Signed-off-by: Jenny Tokar <jtokar at redhat.com>
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py
2 files changed, 17 insertions(+), 3 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Phillip Bailey: Looks good to me, but someone else must approve
  Jenny Tokar: Verified
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/71263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id860888421097336a41b5a4612e58668de20c917
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list