Change in ovirt-engine[master]: core: Fix test in updateVmDiskCommand

Code Review gerrit at ovirt.org
Mon Jul 3 12:23:37 UTC 2017


>From Maor Lipchuk <mlipchuk at redhat.com>:

Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/78875 )

Change subject: core: Fix test in updateVmDiskCommand
......................................................................


core: Fix test in updateVmDiskCommand

the validation which checks whether no amend and extend run together
does not run the command validate method.
Fixing the test to test it properly.

Change-Id: I748da61b43fb360bc3f205d4ed121be49c089781
Bug-Url: https://bugzilla.redhat.com/1464766
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/78875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I748da61b43fb360bc3f205d4ed121be49c089781
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list