Change in ovirt-engine[ovirt-engine-4.1]: core: Update amend validation of RAW volumes in a disk.
Code Review
gerrit at ovirt.org
Tue Jul 4 09:55:17 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/78935 )
Change subject: core: Update amend validation of RAW volumes in a disk.
......................................................................
core: Update amend validation of RAW volumes in a disk.
A more proper way to validate if a disk contains only RAW volumes
on amend, is to check whether a QCOW compat value has been passed in the
parameters.
The change of the validation is neccessery since the following patches which
change amendRequested might exclude this validation.
Change-Id: I5d4102af0926961c874057b7f6ffb721751f4841
Bug-Url: https://bugzilla.redhat.com/1464766
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/78935
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d4102af0926961c874057b7f6ffb721751f4841
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list