Change in ovirt-engine[master]: core: Remove redundant modifiers in QueryType
Code Review
gerrit at ovirt.org
Tue Jul 4 10:40:35 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/78895 )
Change subject: core: Remove redundant modifiers in QueryType
......................................................................
core: Remove redundant modifiers in QueryType
According to Java spec nested enums are implicitely static, no need to
declare them static and enum constructors are implicitely private and no
need to declare it as well
Change-Id: I36bc6ce91a8b67e7d31893ee601925b3654b4153
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/QueryType.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Alexander Wels: Looks good to me, approved
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/78895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36bc6ce91a8b67e7d31893ee601925b3654b4153
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list