Change in ovirt-engine[master]: vdsbroker: refactoring: Remove ResourceManager#getInstance()
Code Review
gerrit at ovirt.org
Tue Jul 4 11:41:59 UTC 2017
>From Martin Betak <mbetak at redhat.com>:
Martin Betak has submitted this change and it was merged. ( https://gerrit.ovirt.org/78821 )
Change subject: vdsbroker: refactoring: Remove ResourceManager#getInstance()
......................................................................
vdsbroker: refactoring: Remove ResourceManager#getInstance()
Removed last usages of the deprecated ResourceManager#getInstance() method.
Where impossible to use CDI field injection (mostly usages reachable from
constructors), manual lookup from the CDI context (using Injector#get())
was preferred.
Change-Id: I7a0fc848ceb0f76a877b9834ce24cd7fad4eab72
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/RefresherFactory.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java
7 files changed, 25 insertions(+), 29 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78821
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a0fc848ceb0f76a877b9834ce24cd7fad4eab72
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list