Change in ovirt-engine[master]: webadmin: image upload - remove fakepath prefix

Code Review gerrit at ovirt.org
Thu Jul 6 09:10:05 UTC 2017


>From Daniel Erez <derez at redhat.com>:

Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/79062 )

Change subject: webadmin: image upload - remove fakepath prefix
......................................................................


webadmin: image upload - remove fakepath prefix

Removed 'C:\fakepath\'[1] prefix added by the browser
to the selected file name.

[1] According to the specifications of HTML5,
a file upload control should not reveal the real local
path to the file you have selected, if you manipulate
its value string with JavaScript. Instead, the string
that is returned by the script, which handles the file
information is c:\fakepath.

Source:
https://acidmartin.wordpress.com/2009/06/09/the-mystery-of-cfakepath-unveiled/

Change-Id: Ia873b88f322a2ded905744753ab6134596bf45c7
Bug-Url: https://bugzilla.redhat.com/1461932
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Daniel Erez: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/79062
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia873b88f322a2ded905744753ab6134596bf45c7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list