Change in ovirt-engine[master]: core: Set default storage format on add storage domain.
Code Review
gerrit at ovirt.org
Thu Jul 6 11:37:02 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79042 )
Change subject: core: Set default storage format on add storage domain.
......................................................................
core: Set default storage format on add storage domain.
Since storage domain can be added without being attached to any
data center, there is no reason to fetch a data center for
detach storage domain to validate storage format.
Change-Id: Iac06a4e205626fbb95075b152fd8fdd11ea6f9e7
Bug-Url: https://bugzilla.redhat.com/1467781
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommonTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageFormatType.java
3 files changed, 6 insertions(+), 35 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
Idan Shaby: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac06a4e205626fbb95075b152fd8fdd11ea6f9e7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list