Change in ovirt-engine[master]: backend: extract main logic of SyncAllStorageDomainsLuns
Code Review
gerrit at ovirt.org
Mon Jul 10 08:24:18 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/78974 )
Change subject: backend: extract main logic of SyncAllStorageDomainsLuns
......................................................................
backend: extract main logic of SyncAllStorageDomainsLuns
This patch extracts the main logic of SyncAllStorageDomainsLuns to a new
abstract class, AbstractSyncStorageDomainsLunsCommand, so that new
classes can extend it and reuse the common code.
Change-Id: I3af0e9a7c60461ae7e7a7cad607778ad0a1680f4
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncStorageDomainsLunsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAllStorageDomainsLunsCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncStorageDomainsLunsCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncAllStorageDomainsLunsCommandTest.java
4 files changed, 206 insertions(+), 153 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/78974
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3af0e9a7c60461ae7e7a7cad607778ad0a1680f4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list