Change in ovirt-engine[master]: core: add vm downtime
Code Review
gerrit at ovirt.org
Mon Jul 10 15:43:05 UTC 2017
>From Arik Hadas <ahadas at redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/78619 )
Change subject: core: add vm downtime
......................................................................
core: add vm downtime
There are few approaches for calculating the elapsed time of a VM.
One approach, that is used today, is to aggregate the time the VM
was running. This approach has some drawbacks.
An alternative approach is to aggregate the time the VM was down
and then to compute the elapsed time according to the current time,
the overall downtime, and the boot time (that is, the time the VM
was started and not restoring an existing memory state).
Since we are going with the latter approach, this patch adds the
VM downtime.
Change-Id: Id5174843c70c485e89f7b5a4c61a8a83a8827fec
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVDSCommandParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_02_0360_add_downtime_to_vm_dynamic.sql
M packaging/dbscripts/vms_sp.sql
13 files changed, 60 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78619
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5174843c70c485e89f7b5a4c61a8a83a8827fec
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list