Change in ovirt-engine[master]: core: Adding validation of PM agent port in BLL

Code Review gerrit at ovirt.org
Tue Jul 11 10:18:53 UTC 2017


>From Eli Mesika <emesika at redhat.com>:

Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/78826 )

Change subject: core: Adding validation of PM agent port in BLL
......................................................................


core: Adding validation of PM agent port in BLL

Adding validation to the PM agent port value if set.
Port values must be numeric.

Port value can be set in 2 ways :

1) Using the port field in UI
2) Using the options field in UI and API

Change-Id: I43ccd7946c5b3eccba323849e7838338e9fdc762
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1442056
Signed-off-by: emesika <emesika at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddFenceAgentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceAgentCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateFenceAgentCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 35 insertions(+), 0 deletions(-)

Approvals:
  Eli Mesika: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78826
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43ccd7946c5b3eccba323849e7838338e9fdc762
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list