Change in jenkins[master]: Remove patchset number from GerritMergedChange.id

Code Review gerrit at ovirt.org
Tue Jul 11 14:48:27 UTC 2017


>From Barak Korren <bkorren at redhat.com>:

Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/78277 )

Change subject: Remove patchset number from GerritMergedChange.id
......................................................................


Remove patchset number from GerritMergedChange.id

The 'id' field for CQ changes is mainly for setting dependencies between
changes. When setting dependencies between Gerrit changes, the patchset
number that will be merged for a required change cannot always be known
at the point in time in which the requiring change is created. Therefore
we can't have the patchset number as part of the change id.

Change-Id: I3f7c5e37c7dafb472d3892fa20b38266f668babe
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1448
Signed-off-by: Barak Korren <bkorren at redhat.com>
---
M scripts/change_queue/changes/__init__.py
M test/change_queue/test_changes.py
2 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me
  Barak Korren: Verified; Looks good to me, approved; Ready for merge
  Gil Shinar: Looks good to me
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/78277
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f7c5e37c7dafb472d3892fa20b38266f668babe
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky at redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>


More information about the Engine-commits mailing list