Change in ovirt-engine[master]: core: MoveOrCopyDiskCommandTest storage type tests

Code Review gerrit at ovirt.org
Wed Jul 12 14:54:44 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79324 )

Change subject: core: MoveOrCopyDiskCommandTest storage type tests
......................................................................


core: MoveOrCopyDiskCommandTest storage type tests

MoveOrCopyDiskCommandTest has a bunch of tests for supported storage
types.
This logic is part of the DiskValidator, not the command, and thus
it makes no sense to test it in MoveOrCopyDiskCommand's UNIT test.

Change-Id: Ifc61b94367c20be21ff45d145eac583e5e8c33f9
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
1 file changed, 0 insertions(+), 42 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/79324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc61b94367c20be21ff45d145eac583e5e8c33f9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list