Change in ovirt-engine[ovirt-engine-4.1]: core: DiskValidator#isDiskAttachedToAnyVm streams

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79334 )

Change subject: core: DiskValidator#isDiskAttachedToAnyVm streams
......................................................................


core: DiskValidator#isDiskAttachedToAnyVm streams

This patches changes the implementation of the isDiskAttachedToAnyVm
method to first generate the list of offending VM names (which should
be a non-op if there are none), and then perform the check on the
generated string instead of the original list.

While this patch doesn't have too much meaning on its own, it sets up
the subsequent patch, which will add another filter clause to the
aforementioned stream.

Change-Id: I7c89929c040c9e6cb7913b24ba2484db34562752
Related-To: https://bugzilla.redhat.com/1414499
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/79334
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7c89929c040c9e6cb7913b24ba2484db34562752
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>