Change in ovirt-engine[ovirt-engine-4.1]: core: Allow transferring for unplugged disks
Code Review
gerrit at ovirt.org
Sun Jul 16 07:51:21 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79336 )
Change subject: core: Allow transferring for unplugged disks
......................................................................
core: Allow transferring for unplugged disks
If a disk is not plugged to a VM, the VM's status is inconsequential.
This patch refines the validation to ignore unplugged disks
Change-Id: I761546f9e41daf74306863ce48f30003fa2de8fd
Bug-Url: https://bugzilla.redhat.com/1414499
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
4 files changed, 43 insertions(+), 27 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79336
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I761546f9e41daf74306863ce48f30003fa2de8fd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
More information about the Engine-commits
mailing list