Change in ovirt-engine[master]: core: added utility methods for huge pages

Code Review gerrit at ovirt.org
Mon Jul 17 10:43:35 UTC 2017


>From Tomas Jelinek <tjelinek at redhat.com>:

Tomas Jelinek has submitted this change and it was merged. ( https://gerrit.ovirt.org/79380 )

Change subject: core: added utility methods for huge pages
......................................................................


core: added utility methods for huge pages

It will mostly be used by the scheduler to know where to schedule this VM to.

Added two methods:
- isBackedByHudepages: returns true if the VM has a custom property defined and
  it is a valid integer
- getHugePages: returns a map "huge page size" -> "required amount". It returns
  it in this format and not as a HugePage object to easy the processing by the
  scheduler.

Implemented in a separate utility class because it can not be part of the
VMBase due to it's dependency on CustomPropertiesUtil and it's transitive
dependencies.

Change-Id: I66fec5a5b367ddadcee8033b4a8932de5be23e57
Bug-Url: https://bugzilla.redhat.com/??????
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/HugePageUtils.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/HugePageUtilsTest.java
2 files changed, 126 insertions(+), 0 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79380
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66fec5a5b367ddadcee8033b4a8932de5be23e57
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list