Change in ovirt-engine[master]: core: remove redundant cast from correlation_id

Code Review gerrit at ovirt.org
Tue Jul 18 12:45:46 UTC 2017


>From Eli Mesika <emesika at redhat.com>:

Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/79551 )

Change subject: core: remove redundant cast from correlation_id
......................................................................


core: remove redundant cast from correlation_id

In the search engine, the ORDER BY  includes a cast to varchar of
correlation_id (correlation_id::varchar), from the other hand, the
selection list has only correlation_id.

Since a column name that appears in ORDER BY must be included exactly in
the same format in the selection list (correlation_id::varchar and
correlation_id are not considered the same), the query fails

This patch removes the redundant casting of correlation_id to varchar
and makes it possible to sort Events by correlation_id.

Change-Id: I440608e7858911ea0df37629475fe2e6d97913f7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1471815
Signed-off-by: emesika <emesika at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/AuditLogConditionFieldAutoCompleter.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Eli Mesika: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I440608e7858911ea0df37629475fe2e6d97913f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list