Change in ovirt-engine-sdk[master]: Raise proper exception when using OpenId
Code Review
gerrit at ovirt.org
Tue Jul 18 13:00:53 UTC 2017
>From Ondra Machacek <omachace at redhat.com>:
Ondra Machacek has submitted this change and it was merged. ( https://gerrit.ovirt.org/79269 )
Change subject: Raise proper exception when using OpenId
......................................................................
Raise proper exception when using OpenId
OpenId can return 'error' and 'error_description' fields in their SSO
JSON reponse. The OAuth can return 'error' and 'error_code', this patch
add support for both.
Change-Id: Iaf8c4a91d2ebf17135ccc90f973128b659929f9e
Bug-Url: https://bugzilla.redhat.com/1468460
Signed-off-by: Ondra Machacek <omachace at redhat.com>
---
M sdk/lib/ovirtsdk4/__init__.py
A sdk/tests/test_invalid_authentication.py
2 files changed, 99 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79269
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf8c4a91d2ebf17135ccc90f973128b659929f9e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list