Change in ovirt-engine[master]: core: ISCSIStorageHelper#filterConnectionsUsedByOthers

Code Review gerrit at ovirt.org
Wed Jul 19 07:00:49 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79539 )

Change subject: core: ISCSIStorageHelper#filterConnectionsUsedByOthers
......................................................................


core: ISCSIStorageHelper#filterConnectionsUsedByOthers

Clear conditional logic so that lunId.isEmpty() is only checked once.

While the performance improvement is negligible, this change cleans
up the code and makes it much easier to read and maintain.

Change-Id: I29c87e251d6cc9ca55fa3fd2caae7d83c135405e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ISCSIStorageHelper.java
1 file changed, 5 insertions(+), 8 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/79539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29c87e251d6cc9ca55fa3fd2caae7d83c135405e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list