Change in ovirt-engine[master]: common: Fix HugePagesUtils units (KiB vs MiB) and make it st...
Code Review
gerrit at ovirt.org
Wed Jul 19 08:21:40 UTC 2017
>From Martin Sivák <msivak at redhat.com>:
Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/79504 )
Change subject: common: Fix HugePagesUtils units (KiB vs MiB) and make it static
......................................................................
common: Fix HugePagesUtils units (KiB vs MiB) and make it static
This fixes an unit mismatch as hugepage size is reported in
kilobytes and the memory size in megabytes.
The unnecesary injection is also removed to make this available
from non-CDI enabled contexts.
Bug-Url: https://bugzilla.redhat.com/1461476
Change-Id: Ibab4e0225c3de1fe04d145ae58887285b94a41f5
Signed-off-by: Martin Sivak <msivak at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/HugePageUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/HugePageUtilsTest.java
2 files changed, 32 insertions(+), 24 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Andrej Krejcir: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79504
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibab4e0225c3de1fe04d145ae58887285b94a41f5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list