Change in ovirt-engine[master]: core: proper NetworkSection in OVF

Code Review gerrit at ovirt.org
Wed Jul 19 10:17:06 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79484 )

Change subject: core: proper NetworkSection in OVF
......................................................................


core: proper NetworkSection in OVF

The OVF specification indicates that the networks section should start
with NetworkSection element rather than Section element with an attribute
of type=NetworkSection_Type. It should also include the logical networks
used by the VM/template instead of a single network called "Network 1"
that we generated until now.

As for backward compatibility, this section was never read by oVirt so
we are safe.

Change-Id: I022a768dbf1bc948cb97eacfb94389f6ecfe9026
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
1 file changed, 7 insertions(+), 8 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I022a768dbf1bc948cb97eacfb94389f6ecfe9026
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list