Change in ovirt-engine[master]: core: CinderProviderValidator#isCinderHasNoImages
Code Review
gerrit at ovirt.org
Wed Jul 19 12:08:52 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79597 )
Change subject: core: CinderProviderValidator#isCinderHasNoImages
......................................................................
core: CinderProviderValidator#isCinderHasNoImages
Commit d14817 changed this method to be an instance method, but
neglected to reuse the ID of the domain it already contains, causing
a regression in StorageDomainCommandBase.
This patch rectifies that mistake.
Change-Id: Icb386ebf97f3fa13d6fcf4a08d53bec01948fb53
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
2 files changed, 9 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79597
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb386ebf97f3fa13d6fcf4a08d53bec01948fb53
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list