Change in ovirt-engine[master]: webadmin: clean ClientGinjectorExtension / shrink initial do...

Code Review gerrit at ovirt.org
Wed Jul 19 13:08:58 UTC 2017


>From Greg Sheremeta <gshereme at redhat.com>:

Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/78968 )

Change subject: webadmin: clean ClientGinjectorExtension / shrink initial download
......................................................................


webadmin: clean ClientGinjectorExtension / shrink initial download

Clean unnecessary helpers from ClientGinjectorExtension. These were being
used in the getTabData methods, but no longer are.

This change further alleviates our GWT initial download size.
Webadmin initial download size is reduced from approximately 4MB
to 2.5MB.

Change-Id: I14bb07950ad551fea402df5fc871bb606277701d
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java
1 file changed, 0 insertions(+), 490 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78968
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I14bb07950ad551fea402df5fc871bb606277701d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list