Change in ovirt-engine[master]: webadmin: extract upload image logic
Code Review
gerrit at ovirt.org
Thu Jul 20 14:33:08 UTC 2017
>From Daniel Erez <derez at redhat.com>:
Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/79485 )
Change subject: webadmin: extract upload image logic
......................................................................
webadmin: extract upload image logic
Extracted the upload image logic form UploadImageModel
to allow reusability by other components (e.g. import
disks from OVA file).
Intorduced:
- UploadImageManager: handles start/resume image uploads
and maintains a list of ongoing uploads (for resume
purposes).
- UploadImageHandler: contains the logic of single
image upload.
Change-Id: I3e3fd79a1b03501d5be274cd7b2f70d246979580
Bug-Url: https://bugzilla.redhat.com/1388970
Signed-off-by: Daniel Erez <derez at redhat.com>
---
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageHandler.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java
4 files changed, 827 insertions(+), 740 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79485
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e3fd79a1b03501d5be274cd7b2f70d246979580
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list