Change in ovirt-engine[master]: webadmin: proper cleanup on UploadImagePopupView
Code Review
gerrit at ovirt.org
Fri Jul 21 09:50:12 UTC 2017
>From Daniel Erez <derez at redhat.com>:
Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/79486 )
Change subject: webadmin: proper cleanup on UploadImagePopupView
......................................................................
webadmin: proper cleanup on UploadImagePopupView
Following extracting upload image logic, we can now
safely invoke driver cleanup on UploadImagePopupView.
Change-Id: I7fd5f251a89a697ddb92d1f7fc8e7c0eaa4df7b8
Bug-Url: https://bugzilla.redhat.com/1388970
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Vojtech Szocs: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79486
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fd5f251a89a697ddb92d1f7fc8e7c0eaa4df7b8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list