Change in jenkins[master]: Fix issues with HTTP retries in mirror_client

Code Review gerrit at ovirt.org
Mon Jul 24 07:29:00 UTC 2017


>From Barak Korren <bkorren at redhat.com>:

Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79038 )

Change subject: Fix issues with HTTP retries in mirror_client
......................................................................


Fix issues with HTTP retries in mirror_client

The retrying loop had a couple of bugs:
1. It was retrying too fast, so was ineffective in practice
2. Exception raising code had an error which caused masking of the
   actual exception that needed to be raised

Change-Id: I060ff165e37c713a1d0ccbe254b3cb0c7c8920c0
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1086
Signed-off-by: Barak Korren <bkorren at redhat.com>
---
M scripts/mirror_client.py
M test/test_mirror_client.py
2 files changed, 19 insertions(+), 3 deletions(-)

Approvals:
  Barak Korren: Verified; Looks good to me, approved; Ready for merge
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/79038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I060ff165e37c713a1d0ccbe254b3cb0c7c8920c0
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky at redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>


More information about the Engine-commits mailing list