Change in ovirt-engine[master]: core: prevent NPE on change of rng of a running vm

[Code Review]

>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79798 )

Change subject: core: prevent NPE on change of rng of a running vm
......................................................................


core: prevent NPE on change of rng of a running vm

We try to preserve the RNG device rather than introducing a new one in
case one changes the rng device of a running VM. However, there was no
protection for the case that someone asks to add an RNG device for a
running VM, and that results in NPE (that was detected by Coverity's
static code analysis). This patch introduces a fix for that - in that
case, we need to add a new RNG device.

Change-Id: I80a231ca8c02890bb9ca7340b8a59973c3c759eb
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79798
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80a231ca8c02890bb9ca7340b8a59973c3c759eb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>