Change in ovirt-engine[master]: db for PG 9.5 : fix sp return type

Code Review gerrit at ovirt.org
Fri Jul 28 09:54:54 UTC 2017


>From Martin Peřina <mperina at redhat.com>:

Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/79910 )

Change subject: db for PG 9.5 : fix sp return type
......................................................................


db for PG 9.5 : fix sp return type

This patch fixes an issue in GetEntitiesNameMap SP that uses the "CREATE
TABLE" syntax to return a result set. (introduced in commit bc050c6f)
This is not the standard way we use although it is legal, we are using a
creation of a TYPE and then returning a SETOF the created TYPE.

The non-standard return value caused engine to crash with jdbc 42.3.1
(latest) and spring 4.3.9 (actually the crash is in spring)

This was a blocker for our planned shift to PG 9.5

After this patch, the engine runs OK and all DB DAO tests PASS.

Change-Id: Ic04b0b2470a173b6e2bc4ba6351bbee40930e604
Signed-off-by: emesika <emesika at redhat.com>
---
M packaging/dbscripts/labels_sp.sql
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Eli Mesika: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/79910
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic04b0b2470a173b6e2bc4ba6351bbee40930e604
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list