Change in ovirt-engine[master]: restapi: use runQuery to get a StorageServerConnection

Code Review gerrit at ovirt.org
Thu Jun 1 08:33:33 UTC 2017


>From Juan Hernandez <juan.hernandez at redhat.com>:

Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: use runQuery to get a StorageServerConnection
......................................................................


restapi: use runQuery to get a StorageServerConnection

BackendStorageDomainsResource -> getStorageServerConnection:
use 'runQuery' instead of 'getEntity' in order to return
a correct error code in case of a missing storage connection
for a storage domain (500 instead of 404).

Change-Id: Idd737198b59dc5feb2fb5e60c0eba96873756919
Bug-Url: https://bugzilla.redhat.com/1448399
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
1 file changed, 12 insertions(+), 3 deletions(-)

Approvals:
  Juan Hernandez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Daniel Erez: Verified



-- 
To view, visit https://gerrit.ovirt.org/77322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd737198b59dc5feb2fb5e60c0eba96873756919
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list