Change in ovirt-engine[ovirt-engine-4.1]: webadmin: edit Vm from pool did not show the RNG config
Code Review
gerrit at ovirt.org
Thu Jun 1 09:16:08 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: edit Vm from pool did not show the RNG config
......................................................................
webadmin: edit Vm from pool did not show the RNG config
The problem was that the updateRngDevice() checked if the getIsRngEnabled() is
changable or not.
This is an incorrect check in the edit VM from pool where (almost) all fields
are disabled.
Solved by removing this check completely because it could never result to
"false".
Change-Id: I00da6580da7c458bdd5585b8e921097880cd83d1
Bug-Url: https://bugzilla.redhat.com/1429912
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
3 files changed, 0 insertions(+), 18 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00da6580da7c458bdd5585b8e921097880cd83d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list