Change in ovirt-engine[master]: core: code simplificatons, to simplify extensibility
Code Review
gerrit at ovirt.org
Thu Jun 1 13:48:06 UTC 2017
>From Alona Kaplan <alkaplan at redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: code simplificatons, to simplify extensibility
......................................................................
core: code simplificatons, to simplify extensibility
code in touched classes was not necessarily complex to just repackage
data from one class to another. I need to touch this code, and without
this changes, these methods would become even more painful to read.
Change-Id: I144f2391c893878ad76a219da3edcf6868546fa8
Bug-Url: https://bugzilla.redhat.com/1445171
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerImpl.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/CollectionUtils.java
4 files changed, 68 insertions(+), 73 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I144f2391c893878ad76a219da3edcf6868546fa8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list