Change in ovirt-engine[master]: core: logic to be insync, shouldn't be dispersed across classes
Code Review
gerrit at ovirt.org
Thu Jun 1 13:48:06 UTC 2017
>From Alona Kaplan <alkaplan at redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: logic to be insync, shouldn't be dispersed across classes
......................................................................
core: logic to be insync, shouldn't be dispersed across classes
… but it should be confined inside of single class
Change-Id: I593d7c961ac97dd905794cfa859066546ec5dd34
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/IsRoleNetworkIpConfigurationValid.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
3 files changed, 75 insertions(+), 45 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76767
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I593d7c961ac97dd905794cfa859066546ec5dd34
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list