Change in ovirt-engine-sdk-ruby[master]: Don't use curl_multi_wait if curl <= 7.28.0

Code Review gerrit at ovirt.org
Fri Jun 2 08:21:41 UTC 2017


>From Juan Hernandez <juan.hernandez at redhat.com>:

Juan Hernandez has submitted this change and it was merged.

Change subject: Don't use curl_multi_wait if curl <= 7.28.0
......................................................................


Don't use curl_multi_wait if curl <= 7.28.0

The curl_multi_wait function was introduced in version 7.28.0 of
libcurl. That version of libcurl isn't available in some environments,
in particular it isn't available in the operating system used by default
in the Travis environment: Ubuntu Precise LTS. As a result the SDK fails
during runtime because of the missing symbol. To avoid that problem this
patch changes the SDK so that during build time it check the version of
the libcurl library, and if it is older than 7.28.0 it uses the 'select'
system call instead.

Change-Id: I2e15d50601baf35445a5162abefd1d67ed24542c
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M sdk/ext/ovirtsdk4c/ov_http_client.c
1 file changed, 26 insertions(+), 2 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/77695
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e15d50601baf35445a5162abefd1d67ed24542c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list