Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Min memory empty value parsing

Code Review gerrit at ovirt.org
Wed Jun 7 07:43:05 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Min memory empty value parsing
......................................................................


webadmin: Min memory empty value parsing

Empty value of 'Physical Memory Guaranteed' in VM dialog was parsed to
'[N/A]' string which is an invalid value. This caused NPE during dialog
confirmation.

Fix: MemorySizeEntityModelTextBoxEditor component is now used to process
min memory. This component is also used for Memory and Max memory.

Change-Id: I75e5666f61977862233c7f152770cce5b2949ec3
Bug-Url: https://bugzilla.redhat.com/1426262
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/77830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75e5666f61977862233c7f152770cce5b2949ec3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list